search

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

Port to Python 3 - preview metadata is bytes #428

Closed quozl closed 5 years ago

quozl commented 5 years ago

Preview metadata in 0.114 and earlier was returned by datastore client as a dbus.ByteArray.

Regression introduced by aa8a5e7 ("Port from Python 2 to six").

Traceback (most recent call last):
  File "/usr/lib/python3.7/dist-packages/jarabe/journal/expandedentry.py", line 378, in _create_preview
    pixbuf = get_preview_pixbuf(metadata.get('preview', ''))
  File "/usr/lib/python3.7/dist-packages/sugar3/graphics/objectchooser.py", line 85, in get_preview_pixbuf
    preview_data = base64.b64decode(preview_data)
  File "/usr/lib/python3.7/base64.py", line 87, in b64decode
    return binascii.a2b_base64(s)
binascii.Error: Invalid base64-encoded string: number of data characters (237) cannot be 1 more than a multiple of 4

Related to https://github.com/sugarlabs/sugar-datastore/issues/16

Requires https://github.com/sugarlabs/sugar-datastore/pull/18/commits/fb1a745159521c2887d8a4141fcfde7aea212481 in https://github.com/sugarlabs/sugar-datastore/pull/18