sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

duplicate locale file #430

Closed jonassmedegaard closed 5 years ago

jonassmedegaard commented 5 years ago

It sems that locale ig and ibo both cover same language - Igbo - one using ISO 639-1 and the other using ISO 639-2/ISO 639-3:

https://en.wikipedia.org/wiki/Igbo_language

Also, it seems wrong for ig.po to change the printf identifier in its translation, adding a space from "%d" to "% d".

All in all - without knowing the language(s) involved (and annoyingly the metadata field is not really used), it seems the newer of the files - ibo.po should replace the older ig.po.

quozl commented 5 years ago

I agree, thanks. ig.po from 12a6d2bccba55a75037b9a87013ea0b16c3ae00b seems obviously wrong, given the format directives are changed. But it does seem functionally harmless;

host:~$ python3 -c 'print("is% d bottles" % 42)'
is 42 bottles
host:~$ python3 -c 'print("is %d bottles" % 42)'
is 42 bottles
host:~$ █

ibo.po 9b687cab3f1a0da6e4f01330202ed2e8b2b72e9f came from translate.sugarlabs.org.

@samswag, as the Igbo translation team leader, can you explain it? Please also review https://salsa.debian.org/pkg-sugar-team/sugar-toolkit-gtk3/commit/a2bfc2972cab21c2acbd5c1f3c15a7d14a6228a0 for the change I'm inclined to merge.

quozl commented 5 years ago

@chimosky, it seems @samswag is too busy, do you have any skills in this?

jonassmedegaard commented 5 years ago

Try make a simple diff between the two po files - there is zero linguistic differences ;-)

--

samswag commented 5 years ago

How can I help?

On Thu, Sep 12, 2019, 5:31 AM James Cameron notifications@github.com wrote:

@chimosky https://github.com/chimosky, it seems @samswag https://github.com/samswag is too busy, do you have any skills in this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/430?email_source=notifications&email_token=ABOEWWNYCH5XWKLVGOW6APLQJHA3RA5CNFSM4IUYOBBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QTXHQ#issuecomment-530660254, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOEWWLPQOM2NQVO4S55SMLQJHA3RANCNFSM4IUYOBBA .

quozl commented 5 years ago

@jonassmedegaard, thanks, merged.

@samswag, there are some new strings that need translation. https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/po/ig.po