search

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

Build by default for python 3 #444

Closed quozl closed 4 years ago

quozl commented 4 years ago

5fa33b2 introduced build for either python 2 or python 3, with the default of python 2.

configure and autogen.sh now accept --with-python3 or --with-python2 options, with the default of python 3.

Signed-off-by: James Cameron quozl@laptop.org

quozl commented 4 years ago

@chimosky, does this build properly on Fedora?

chimosky commented 4 years ago

I'll have to wait for this to be merged then patch on fedora and wait for the next compose to test as that's how I'll check for the errors reported.

quozl commented 4 years ago

It isn't necessary to wait. You can change the version in configure.ac to end in ~ibiam.0, then use make dist to build a tarball, then use that tarball with rpmbuild and a modified spec file. Sorry, I don't have time to test on Fedora.

Also updated Sugar Live Build. https://github.com/sugarlabs/sugar-live-build/commit/dbf06fa6631837de09e4fd14ac98928764740f78

chimosky commented 4 years ago

I understand what you're saying, I'm saying for the particular error that this is supposed to fix I'll have to wait for a compose as building a spec file won't show me the error.

quozl commented 4 years ago

This pull request is not intended to fix any error.

chimosky commented 4 years ago

Tested, builds as expected.