sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

No icon is present for description tab in activities's toolbar #465

Closed S-kus closed 5 months ago

S-kus commented 2 years ago

After opening any activity or even terminal, no icon is rendering for the description tab, not on hovering or clicking as well. As shown below:

sec

third

quozl commented 2 years ago

Thanks for testing. As this is rendered by the toolkit, I'll move the issue there.

S-kus commented 2 years ago

@quozl @chimosky Could you please confirm which icon should be rendered there as in Sugarizer activities the Activity Icon is used for this place.

quozl commented 2 years ago

Huh? It's not an oversight, it's a bug. The icon is edit-description and is set here;

https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/activity/widgets.py#L250

Icon source is here;

https://github.com/sugarlabs/sugar-artwork/blob/master/icons/scalable/actions/edit-description.svg

Do you have conflicting evidence? Thanks.

S-kus commented 2 years ago

It's not an oversight, it's a bug

Thanks, @quozl, I am working on it to solve the problem.

Do you have conflicting evidence? Thanks.

No, sorry I misunderstood.

quozl commented 5 months ago

Fixed by https://github.com/sugarlabs/sugar-artwork/commit/7efad05971afc05e90048fb90d5ece75f5d9ba31