search

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

Fix issue with Buddy.props.key being bytes #470

Closed chimosky closed 7 months ago

chimosky commented 7 months ago

Fixes #443

Buddy.props.key is supposed to be a str, but is stored as a dbus.ByteArray before being sent to dbus, decoding it after the call to GetProperties fixes the issue of it being bytes.

Activities like maze that use Buddy.props.key needed to encode the received key before comparison worked.

@quozl kindly review.

Tested without key = str(key.encode()) in maze activity and collaboration works as expected.

quozl commented 7 months ago

Looks fine. Guess you'll need to version the fix in Maze now.

chimosky commented 7 months ago

Done.