search

sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

Update to the latest karma config format #104

Closed dnarvaez closed 10 years ago

dnarvaez commented 10 years ago

We don't specific browsers in the config anymore, we will pass it transparenty on the command line from sugar-build. This is because we need the full path now and we cannot hard code that.

code-sur commented 10 years ago

@dnarvaez, this PR works well in my env, good job. @rogemita can you try it out in yours? (just for double checking)

The "Add bzip as dep" commit (from sugar-build master) as well as the commit from newkarma branch are needed, so I would like you ( @dnarvaez ) to rebase the newkarma branch with master before pushing to sugar-build, please.

I think that changes from both repos (build and web) depend on each other... so, pushing only sugar-build will break the build and vice versa... I don't know if we should try to make these changes incremental, non-braeking ones.

On the other hand, this PR (with the karma config) looks good to me.

Great job and thanks!

dnarvaez commented 10 years ago

I think it's fine to "break" the build if we push both at the same time. I mean ideally we wouldn't, but it's probably not worth the effort in this case.

code-sur commented 10 years ago

yeah, you are right.

Thanks!

rogemita commented 10 years ago

Works great, and config file looks well!

rogemita commented 10 years ago

@dnarvaez I noticed that if the environment is clean/empty, there is no process running volo automatically for getting dependencies, when Karma was failed because mustache, webL10n, text missed dependencies, I did it manually. How this is achieved on ci?

rogemita commented 10 years ago

@dnarvaez Sorry Daniel, the answer is "check" process does that automatically =), I had run karma before check