search

sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

Merge Sugarizer web into Sugar web #110

Closed llaske closed 10 years ago

llaske commented 10 years ago

Using protocol don't work on webkit1

manuq commented 10 years ago

Not sure what to do here. This is a fix for WebKitGTk1, and we encourage further development in WebKitGTk2.

Maybe this JS can be injected in sugar3/activity/webkit1.py ?

llaske commented 10 years ago

Merge Sugarizer web into Sugar web

dnarvaez commented 10 years ago

This is difficult to review because of all the code moving in datastore.js. When moving a lot of code please do it in a separate commit, without making any changes first.

Also I'd like to avoid the huge if in there. What about adding datastore/sugarizer.js and datastore/native.js (sugar? sugaros?), then import those inside datastore.js conditionally? @manuq I would also like your opinion about that.

llaske commented 10 years ago

@dnarvaez okay I could split code in another file but the difficulty here is that both Sugar and Sugarizer should share exactly the same interface. I can work on this but I would like to have @manuq feedbacks too.

dnarvaez commented 10 years ago

An easy way to ensure they have the same interface would be to run test/functional/datastoreSpec.js on both.