Merge SugarOS/Sugarizer

sugarlabs / sugar-web

Components for Sugar web activities

Apache License 2.0

13 stars 32 forks source link

Merge SugarOS/Sugarizer #111

Closed llaske closed 10 years ago

llaske commented 10 years ago

Retry to merge SugarOS/Sugarizer:

datastore.js implementation is now split into two files (sugarizer.js, sugaros.js) in a datastore subdirectory
env.js create environment object in a better way,
bus.js use timeout for callback and remove unused intercepted call.

dnarvaez commented 10 years ago

When resubmitting a pr please rebase as explained on developer.sugarlabs.org. Thanks!

llaske commented 10 years ago

Sorry not familiar with this. I've canceled my previous commit. It's not what you've expected ? Do you expect that I create a new branch then commit my code inside ? Thanks for being patient with my review.

dnarvaez commented 10 years ago

See http://developer.sugarlabs.org/contributing.md.html#sending%20a%20pull-request the section starting with "In case they ask you for changes...". If anything is unclear there please let me know!

Thanks for being patient with my review :)