sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

Support for IE6 #115

Closed mrahul17 closed 10 years ago

mrahul17 commented 10 years ago

I am just beginning to contribute to the sugarlabs community.

mrahul17 commented 10 years ago

Yes, they do. Actually I keep a installation of IE6 for testing out purposes :)

samdroid-apps commented 10 years ago

Cool?! I think @godiard @walterbender and others will need to make the discion as to support sugar web on (really) old browsers. Other wise it looks good!

BTW the style seems to be:

if (cond) {
    // do stuff
} else {
    // do other stuff
}

So spaces would be nice

mrahul17 commented 10 years ago

suggestion acknowledged.

godiard commented 10 years ago

Hi @rahulmr , welcome and thanks for contribute.

I am a little rusty regarding the web stuff, but still remember IE6 was a nightmare, and today nobody support it (even Microsoft). Then I think is better don't complicate the code with workarounds for IE6 implementations if we finally will not be able to implement all what we need on that browser.

About the spaces, @SAMdroid-apps do we have something like pep8 for the js stuff?

samdroid-apps commented 10 years ago

About the spaces, @SAMdroid-apps do we have something like pep8 for the js stuff?

I do not know :)

Do we want to make a decision about this pull request @godiard? I'm edging towards not merging this, as IE6 support will be:

godiard commented 10 years ago

I agree, support IE6 is not a objective, and we can't really be sure all will work. Added to that, the web activities are using websockets an the canvas element, then will not work anyway.