search

sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

check for standalone mode in save method #88

Closed code-sur closed 10 years ago

code-sur commented 10 years ago

@dnarvaez, @manuq I beg your perdon.

you seem to be reading more than there really is into it...

...sure it is.

I'm totally mistified of why you would think I'm being tough. I pointed out an issue with your patch.

From my point of view (mistaken), the fact that a relative old pull-request has an issue that brings up within a later quick patch, seemed to me like you weren't paying attention to the @manuq's patch as with mine. Again as you said:

you seem to be reading more than there really is into it...

Certainly, today is not my day, I had a bad answer and I feel sorry for that.

What should I have done? Blindly merged your patch? I would complain if someone did that to me, so I try to not do it with others.

+1, of course, I don't want you to blindly merge anything, specially mine. Feedback will be welcome (that wasn't what pissed me off), indeed, I've already thought of adding an interface to wrap the question "isStandalone()".

Maybe "want" was the issue here? Change it into "prefer", that's what I meant.

There is a gap between me and the language that surely doesn't help in these cases, but the issue here was myself in a bad day...

Sorry, again and I hope that this won't keep you off giving me feedback.

Thanks.

dnarvaez commented 10 years ago

@code-sur I'm delighted that the misunderstanding has been cleared! We all have our days and language is often a barrier with so many cultures around, luckily we can let code talk! :)

Thanks a lot for your patch, keep up the good work!