search

sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

Try2 - env.isStandalone method using window.location protocol "activity:", then use it on dictstore. #91

Closed rogemita closed 10 years ago

rogemita commented 10 years ago

Discussed at: http://lists.sugarlabs.org/archive/sugar-devel/2013-November/046129.html

dnarvaez commented 10 years ago

Looks like you pushed a new commit to the branch. Let's review and land that separately, after we have got your first set in.

rogemita commented 10 years ago

Yes, the new commit is just a missing test for dictstore, if you want, I will remove of this pull-request and later I will do a new pull-request with this new commit, just tell me =)

dnarvaez commented 10 years ago

Yeah please let's handle that in a separate request, thanks! (Better to not add new code while a review is in progress)

rogemita commented 10 years ago

ok, I will prepare try3 with corrections