search

sugarlabs / sugar-web

Components for Sugar web activities
Apache License 2.0
13 stars 32 forks source link

Try3 - env.isStandalone method using window.location protocol "activity:", then use it on dictstore. #93

Closed rogemita closed 10 years ago

rogemita commented 10 years ago

Discussed at: http://lists.sugarlabs.org/archive/sugar-devel/2013-November/046129.html

dnarvaez commented 10 years ago

Ok to push with that change. I won't have access to a laptop for a while, so I can't push it for you. I'll give you write access so that you can push yourself.

dnarvaez commented 10 years ago

You should have write access now, let me know if you run into issues.

rogemita commented 10 years ago

Ok, I will change that =). Should I make try4 or push force squashing this change?

dnarvaez commented 10 years ago

I don't need to review the changes. Personally I would rebase, merge on master and then push directly to sugarlabs/sugar.. Just be careful to not use force with that repo :) I try to avoid force in general to not risk getting confused and force-pushing to upstream. Wish we had a way to disable force-push for upstream repos but we don't.

rogemita commented 10 years ago

Merged!