search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
263 stars 243 forks source link

Password visibility toggle #693

Closed iamutkarshtiwari closed 8 years ago

iamutkarshtiwari commented 8 years ago

This fixes the issue - https://bugs.sugarlabs.org/ticket/4963

Now the user can toggle the password visiblility via 'show password' checkButton provided

desktop-animation

samdroid-apps commented 8 years ago

Looks good. I totally agree with the patch.

Maybe we could default to it being visible? Visible is more usable :) In a school context, is the WiFi password really secret? I also think that windows 10 defaults to visible wifi passwords, but don't trust me on that.

iamutkarshtiwari commented 8 years ago

fixed.

samdroid-apps commented 8 years ago

Great. I'll merge it! But can you just squash 'em commits?

iamutkarshtiwari commented 8 years ago

Squashed.

quozl commented 8 years ago

@iamutkarshtiwari, please review #703.