search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

Homewindow desktop component #710

Closed icarito closed 7 years ago

icarito commented 8 years ago

This patch set allows to run Sugar as a root window handler.

To try using osbuild, first apply patch then:

$ ./osbuild shell
$ build
$ sugar

You should see the Sugar home window use your desktop workarea, like this: captura de pantalla de 2016-08-03 00-03-48

quozl commented 8 years ago

Nice and simple implementation with very good results, thanks.

My guess is that e1ae8d6 might also fix the busy cursor that persists when user switches to neighbourhood view as soon as Sugar starts but before Journal has started.

samdroid-apps commented 8 years ago

Looks great! Just causes a small regression as noted above. Please fix that before we merge it!

icarito commented 8 years ago

There I fixed it! :-)

icarito commented 8 years ago

Ouch now the Journal doesn't show in the Frame...

samdroid-apps commented 8 years ago

Did you find out why the journal was not showing in the frame?

An alternative could be to make the journal a zoom level rather than an activity. Then, you could just treat it as a special case. This is a feature request that seems to always come up, so I wouldn't have an issue with merging it.

icarito commented 8 years ago

If we leave out commit https://github.com/sugarlabs/sugar/pull/710/commits/30981aaf9dfda0bab84f73f98d53f397877d0a99 then I think this could be merged. The issue doesn't affect regular users, only those that start Sugar as a secondary widget. The real issue is that the Frame doesn't scan for windows on startup but assumes it's first to start and from then on I think only monitors "new window" events.

I don't think coupling the journal deeper into the shell will serve any purpose. If anything we should make it run as a separate process. Then we could seamlessly try new implementations.

I recommend to merge all but https://github.com/sugarlabs/sugar/pull/710/commits/30981aaf9dfda0bab84f73f98d53f397877d0a99 and we can create a pending task for the Frame to scan windows on startup (I'll do it eventually).

icarito commented 8 years ago

are we using bugs.sugarlabs to track tasks? :-/