search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
262 stars 242 forks source link

GSettings for SaveAs functionality #750

Closed iamutkarshtiwari closed 7 years ago

iamutkarshtiwari commented 7 years ago

A new boolean value is now added to gsettings to toggle the Save-As functionality on activity close-

1) If the value is TRUE- Save As popup appears 2) the value is FALSE - Default jobjects write to journal (without Save As)

This GSetting value can be toggled from terminal by the following command - $ gsettings set org.sugarlabs.journal save-as false(To enable Save-As)

$ gsettings set org.sugarlabs.journal save-as true (To disable Save-As)

tony37 commented 7 years ago

I think your items 1 and 2 may be reversed,

Tony

On 04/25/2017 01:31 AM, Utkarsh Tiwari wrote:

A new boolean value is now added to gsettings to toggle the |Save-As| functionality on activity close-

  1. If the value is TRUE- Save As popup appears
  2. the value is FALSE - Default jobjects write to journal (without Save As)

This GSetting value can be toggled from terminal by the following command - $ gsettings set org.sugarlabs.user save-as false (To enable Save-As)

$ gsettings set org.sugarlabs.user save-as true (To disable Save-As)

    You can view, comment on, or merge this pull request online at:

https://github.com/sugarlabs/sugar/pull/750

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/sugar/pull/750, or mute the thread https://github.com/notifications/unsubscribe-auth/AAULkn7PBgXXVO6HkXzjuS2cNmAK4aIWks5rzNx3gaJpZM4NGefo.

tony37 commented 7 years ago

Sorry, my mistake. I misread the text.

Tony

On 04/25/2017 01:31 AM, Utkarsh Tiwari wrote:

A new boolean value is now added to gsettings to toggle the |Save-As| functionality on activity close-

  1. If the value is TRUE- Save As popup appears
  2. the value is FALSE - Default jobjects write to journal (without Save As)

This GSetting value can be toggled from terminal by the following command - $ gsettings set org.sugarlabs.user save-as false (To enable Save-As)

$ gsettings set org.sugarlabs.user save-as true (To disable Save-As)

    You can view, comment on, or merge this pull request online at:

https://github.com/sugarlabs/sugar/pull/750

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/sugar/pull/750, or mute the thread https://github.com/notifications/unsubscribe-auth/AAULkn7PBgXXVO6HkXzjuS2cNmAK4aIWks5rzNx3gaJpZM4NGefo.

iamutkarshtiwari commented 7 years ago

@quozl Please review -

quozl commented 7 years ago

Thanks.

quozl commented 7 years ago

Holding off on merge until https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327 is ready.

quozl commented 7 years ago

Rebased and merged as f8b310490c1e6f388acaf87705a573d7e60f39bf.