Paste fails when frame contains multiple copies

sugarlabs / sugar

Sugar GTK shell

GNU General Public License v3.0

255 stars 241 forks source link

Paste fails when frame contains multiple copies #783

Open quozl opened 6 years ago

quozl commented 6 years ago

Reproducer:

start Sugar 0.112,
start Terminal,
display some text,
select and copy some text using ctrl+shift+c; the frame will show a text clipping,
select and copy some other text using ctrl+shift+c; the frame will show two text clippings,
paste the text using ctrl+shift+v,

Expected result:

most recent text clipping is pasted,

Observed result:

nothing happens.

Logs: nothing unusual in Terminal log, but shell.log contains these two lines for each ctrl+shift+c key event,

1517518078.319098 WARNING root: no data for selection target MULTIPLE.
1517518078.328716 WARNING root: no data for selection target NULL.

Reported by @Menzador.

Menzador commented 6 years ago

Can confirm. The original test case was 0.110 on several machines, mostly running Ubuntu 17.04. The latest 2 cases were on 17.10 systems, one on a Toshiba (technically running System76's Pop!_OS, which is Ubuntu with a few cosmetic changes), and one on a MacBook Pro running Ubuntu MATE 17.10. @quozl tested for 0.112.

Seems like it's throwing a null pointer someplace.

EDIT 1: Any clipping, not just text, behaves this way. I tested with an image I made, posted to Imgur, and copied directly (hotlink-style).

rhl-bthr commented 6 years ago

Unable to reproduce

started Sugar 0.112,
started Terminal,
displayed some text
selected and copied some text using ctrl+shift+c; No frame appears
selected and copied some other text using ctrl+shift+c; Again, no frame appears
pasted the text using ctrl+shift+v,

Observed result:

The recent clipping is pasted

Tested on: Ubuntu 16.04, rdesktop. Sugar 0.112

quozl commented 6 years ago

Reproduced on Ubuntu 16.04 with Sugar 0.112 as a VM.

Reproduced on Ubuntu 16.04 with Sugar 0.112 as a native desktop on real hardware.

I don't expect rdesktop to fully emulate the native environment, so I'm not surprised rdesktop does not reproduce this problem. As it reproduces with a VM, your best bet to reproduce (if you need to) is down that path. rdesktop is not an expected use-case.

rhl-bthr commented 6 years ago

@quozl, Thank you for the detailed explanation