Fix: Toggle Favorite star when there is only one entry

rhl-bthr commented 6 years ago

Fixed in this PR:

Explanation of the issue:

For only one entry, on clicking the favorite icon, clicked signal was emitted, _favorite_clicked_cb was called, and self._model was updated, but the display was not updated

Changes made:

If there is only one entry in the journal, call _do_refresh from _favorite_clicked_cb

Investigation:

_favorite_clicked_cb is called
The cell_rect values are correct
Triple clicking(odd clicks) updates the icon. Essentially, more than one simultaneous click updates the display. Could be similar to what @quozl explained here

rhl-bthr commented 6 years ago

@quozl, kindly review

quozl commented 6 years ago

Reviewed. Tested on Ubuntu 18.04. Unfortunate that we don't know what the problem is caused by.

rhl-bthr commented 6 years ago

Agreed. I will submit a patch if I find the actual cause.

I anticipate more such issues might come while porting to Python3 (and some existing ones might get mysteriously resolved)

sugarlabs / sugar