[Feature]: Add accessibility keys to Journal

[rhl-bthr]

Feature: https://bugs.sugarlabs.org/ticket/4891

This is an update to the existing PR #667

Updates done (requested in #667):

• [X] Pressing Return in detail view resumes the activity
• [X] Use ctrl + f to focus on search
• [X] Search does not lose focus after a timeout

Other Updates:

• [X] Press ctrl + F2 to rename an entry
• [X] Pressing enter key in title editing in detail view removes the focus from it.
• [X] 22382d6 (Unrelated to the PR - fixes errors shown in logs)

Could not be fixed:

• [x] Rename an entry, press enter, arrow keys need to be pressed twice to start scrolling. This issue ocurrs only the first time we try to rename. Further renaming works as expected
• [ ] Ctrl + 1, Ctrl + 2 ... to switch between Journal, Documents and mounts: Attempts:
  • emitted toggled signal. The connected function is called but no change is observed. Logs didn't show anything unexpected
  • emitted clicked signal. Same output as with toggled
  • called __volume_changed_cb directly with appropriate checks and arguments. Same output as above

@quozl, Kindly review

[rhl-bthr]

Update on the PR:

• [X] Fix sound alert while returning from detail view to main view
• [X] Fix the need to use arrow keys twice after renaming entries for the first time

[rhl-bthr]

Also requesting others to review and suggest more improvements

[rhl-bthr]

Update: Commit message updated to detect co-author @iamutkarshtiwari in 2670767

@quozl, is this change approproate

[quozl]

Tested e429e95 on Ubuntu 16.04.

Curious behaviour; can you reproduce this;

• produce less than a full screen of journal entries, and switch to it with f5 key,
• position mouse cursor in whitespace below last entry,
• press down arrow key repeatedly until last entry is highlighted,
• briefly move the mouse cursor up into the last entry and then back to the whitespace below,
• press escape key.

Expected result: nothing.

Observed result: area below list is shaded grey.

[rhl-bthr]

I am able to reproduce the effect. I remember seeing this effect in one of the activities as well, not sure which.

Another way to reproduce the same effect is:

• Keep scrolling until the last activity using down arrow key.
• Press right arrow key to switch to detail view
• Press left arrow key to switch back to main view
• The area gets highlighted

I will try to find the cause and a fix for this

[rhl-bthr]

Update: The shading of the bottom empty area:

• Fixed for Escape key-press
• Ocurrs on going to the last entry using down key and pressing
  • ctrl+f2 and then escape
  • ctrl+f and then escape
  • right and then left

I am unable to find a cause or a fix for this. The area gets shaded when the last entry is in focus and then loses focus. Requesting help from developers on the same.

[quozl]

Requesting help from developers on the same.

Developers of GTK+ may be helpful. Write a stand-alone program that reproduces the problem, then iteratively remove as much as possible from the program until the program is as small as possible yet still reproduces. Then post a pointer to the program to a GTK+ mailing list or issue tracker and ask for help.

[chimosky]

@quozl could you share the branch this work is being done on if you still have it? The branch has been deleted by the author.

[jcameron-sso]

You can still do this;

git fetch origin pull/791/head
git checkout abc62125c

therefore the branch being deleted is of no consequence.

[chimosky]

You can still do this;

git fetch origin pull/791/head
git checkout abc62125c

therefore the branch being deleted is of no consequence.

Thanks.

[chimosky]

Moved to #959.