Closed rhl-bthr closed 2 years ago
Update on the PR:
detail
view to main
viewAlso requesting others to review and suggest more improvements
Update: Commit message updated to detect co-author @iamutkarshtiwari in 2670767
@quozl, is this change approproate
Tested e429e95 on Ubuntu 16.04.
Curious behaviour; can you reproduce this;
escape
key.Expected result: nothing.
Observed result: area below list is shaded grey.
I am able to reproduce the effect. I remember seeing this effect in one of the activities as well, not sure which.
Another way to reproduce the same effect is:
down
arrow key.right
arrow key to switch to detail viewleft
arrow key to switch back to main viewI will try to find the cause and a fix for this
Update: The shading of the bottom empty area:
Escape
key-pressdown
key and pressing
ctrl
+f2
and then escape
ctrl
+f
and then escape
right
and then left
I am unable to find a cause or a fix for this. The area gets shaded when the last entry is in focus and then loses focus. Requesting help from developers on the same.
Requesting help from developers on the same.
Developers of GTK+ may be helpful. Write a stand-alone program that reproduces the problem, then iteratively remove as much as possible from the program until the program is as small as possible yet still reproduces. Then post a pointer to the program to a GTK+ mailing list or issue tracker and ask for help.
@quozl could you share the branch this work is being done on if you still have it? The branch has been deleted by the author.
You can still do this;
git fetch origin pull/791/head
git checkout abc62125c
therefore the branch being deleted is of no consequence.
You can still do this;
git fetch origin pull/791/head git checkout abc62125c
therefore the branch being deleted is of no consequence.
Thanks.
Moved to #959.
Feature: https://bugs.sugarlabs.org/ticket/4891
This is an update to the existing PR #667
Updates done (requested in #667):
Return
in detail view resumes the activityctrl + f
to focus on searchOther Updates:
ctrl + F2
to rename an entryenter
key in title editing in detail view removes the focus from it.Could not be fixed:
enter
, arrow keys need to be pressed twice to start scrolling. This issue ocurrs only the first time we try to rename. Further renaming works as expectedCtrl + 1
,Ctrl + 2
... to switch between Journal, Documents and mounts: Attempts:toggled
signal. The connected function is called but no change is observed. Logs didn't show anything unexpectedclicked
signal. Same output as withtoggled
__volume_changed_cb
directly with appropriate checks and arguments. Same output as above@quozl, Kindly review