search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

jarabe, extensions - remove GConf compatibility #792

Closed quozl closed 6 years ago

quozl commented 6 years ago

GConf compatibility support in Sugar allowed activities to read or be notified of changes to age, gender, nick, user colour, collaboration server, backup server, or automatic power management. Redundant code updated GConf values at the same time as updates to Gio.Settings values.

Remove GConf from Sugar;

Warning: may break some activities. May cause default values to be used, traceback, or fail to start for any activity using the removed GConf schema to read the removed configuration values for; age, gender, nick, user colour, collaboration server, backup server, and automatic power management. Fix GTK+ 2 activities by porting to GTK+ 3 and Gio.Settings. Fix GTK+ 3 activities by porting from GConf to Gio.Settings.

Tested on Ubuntu 16.04.

tony37 commented 6 years ago

Another make-work project for developers. The best solution would be to return to the config file in /home/olpc/.sugar/defaults. That has no dependency on upstream and is therefore immune from these diktats.

Tony

On Monday, 26 March, 2018 05:59 AM, James Cameron wrote:

*

removes GConf dependency,

*

breaks GTK+ 2 activities; this version of Sugar will cause
traceback and fail to start for any activity using a GConf schema
to read configuration values for; age, gender, nick, user colour,
collaboration server, backup server, automatic power management.

Untested.

    You can view, comment on, or merge this pull request online at:

https://github.com/sugarlabs/sugar/pull/792

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/sugar/pull/792, or mute the thread https://github.com/notifications/unsubscribe-auth/AAULkvLKzn1-QCfA90dFbQ6N1b6NGHNyks5tiGeXgaJpZM4S6fTR.

quozl commented 6 years ago

Returning to a defaults file would break compatibility with settings made by builders or shell scripts. It would also lose locking, and settings change notification.

We could also avoid GTK+ and use something more stable like X or Qt, but such a port would be a huge make-work. With the withdrawal of GTK+ 2 we lose the use of many abandoned activities.