social icon added in README

[ghost]

Added icon according to website

[quozl]

You forgot to link to the issue. https://github.com/sugarlabs/sugar/issues/797

Reviewed 233515a.

In my opinion, none of these accounts are used by developers who work on Sugar itself; that is the set of people who have made commits to this repository does not contain any of these account owners. It would be a misrepresentation.

That said;

• [ ] please verify with Sugar Labs Oversight Board (@walterbender?) that these four accounts are controlled by Sugar Labs; if not, mark the accounts clearly as to the member who owns and operates them,
• [ ] add the text just after the link to the web site, not in the section "Building",
• [ ] either add the SVGs here, rather than rely on a third-party web site, or do not use icons.

Thanks!

[walterbender]

@samswag Can the marketing team please review these links? thx.

[ghost]

@quozl This looks not so good. Any better solution?

[quozl]

The appearance quality is fine. It is a README.md file, after all. The format and syntax is intentionally restricted. You might add a line break after the link to www.sugarlabs.org.

But this does not address my primary concerns.

[samswag]

Yes the links are correct @walterbender.

[ghost]

@quozl @samswag Can anybody review this?

[quozl]

Reviewed to c3a0702. I've no issues with layout, it looks fine.

Sorry, we can't merge those icons into the software package because they don't have a compatible license. A "make dist" build step would add them to the release tar.xz file, and then we couldn't distribute the file.

Please move the icons to the www-sugarlabs repository and then use the links to them on our web server.

Please use a new pull request. I'm closing this one because I don't want these commercial icons to accidentally end up in the repository, which they would if the pull request was merged at this point.

Let me know if you have any questions. I look forward to the next pull request! :grinning:

[ghost]

I got it from here and its is under MIT license which is free to use and distribute. https://github.com/konsav/social-icons

[quozl]

@drashti4, thanks.

@walterbender, does Sugar Labs need a license to use these trademarks? :grin: I've just never come across anyone asking to add trademarked commercial logos to open source software that aren't part of the software in any way.

[rhl-bthr]

I am against adding this to the ReadMe, since it's not useful for the intended audience of the ReadMe

[quozl]

Thanks. I agree.