sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

embed gwebsockets in jarabe instead of a separate package #803

Closed rhl-bthr closed 6 years ago

rhl-bthr commented 6 years ago

Since python-gwebsockets is not used by anyone else other than us, other than us, should it be safe to embed it in the code itself ?

Reference Links: https://www.archlinux.org/packages/community/any/python2-gwebsockets/ http://fedora.portingdb.xyz/pkg/gwebsockets/

Tested on: Ubuntu 16.04, Sugar 0.112

quozl commented 6 years ago

It has usefulness on its own. We don't know it is not used by others. It is in Pypi. There are 202 code references to gwebsockets across all of GitHub. Downstreams are likely to continue to package it. Based on these observations, I don't think it should be embedded.

rhl-bthr commented 6 years ago

Sorry, I had missed PyPI. Thanks.