sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

Port from GObject to GLib #804

Closed rhl-bthr closed 6 years ago

rhl-bthr commented 6 years ago

While I have made the changes discussed in https://github.com/orgs/sugarlabs/projects/5, please mention if I have missed any

quozl commented 6 years ago

Thanks. Reviewed to 7af77eac.

... at this point I got bored and figured I could just use flake8 twice and compare,

git checkout master
python -m flake8 . > flake8-master
git checkout port-gobject-glib
python -m flake8 . > flake8-glib
meld flake8-master flake8-glib

Much nicer. Leave it to you?

(p.s. there are plenty of flake8 issues already, so the compare output method can help instead.)

rhl-bthr commented 6 years ago

Thanks. Sorry for not verifying earlier.

Fixed all instances.

quozl commented 6 years ago

Thanks. Reviewed 93095ce using flake8 comparison.

extensions/cpsection/aboutme/view.py:368:13: F821 undefined name 'GLib'
extensions/cpsection/aboutme/view.py:369:26: F821 undefined name 'GLib'
src/jarabe/main.py:62:1: F401 'GObject' imported but unused
src/jarabe/view/keyhandler.py:20:1: F401 'GObject' imported but unused
src/jarabe/view/keyhandler.py:167:13: F821 undefined name 'GLib'

Also several argument list indentation changes, and a few line too long.

rhl-bthr commented 6 years ago

Thanks. Running flake8 didn't show these errors for me. Diagnosing.

Fixed the instances and set PEP8

quozl commented 6 years ago

Thanks. a5f87d1 is nearly there, though keyhandler.py still has a GObject import unused (F401).

c0d53eb is more than is needed, and I don't have time to review it, my preference is to omit it, as there's the pending python3 branch to merge with eventually.

As for why flake8 didn't show them for you;

rhl-bthr commented 6 years ago

Thanks again. Please re review