sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

Journal - iconify again if Metacity misbehaves (RHBZ #1519042) #810

Closed quozl closed 5 years ago

quozl commented 5 years ago

Journal covers Home View on startup when Metacity is 3.25.1 or later, isolated to Metacity 6875256 ("unminimize windows with initial IconicState if first known on MapRequest").

Detect the window state event where ICONIFIED is cleared without any action by the user. Repeat the iconify request.

Has side-effect of showing a Metacity iconify animation, but this is better than not fixing it.

Fixes https://github.com/sugarlabs/sugar/issues/769

Fixes https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/368

Tested on Fedora 18 and Ubuntu 16.04; does not trigger.

Tested on Ubuntu 18.04; does trigger.

quozl commented 5 years ago

Was tested on Fedora 29 by @FGrose.

quozl commented 5 years ago

Was tested on Fedora 30 by @satellitee.

quozl commented 5 years ago

Underlying problem has been fixed in https://github.com/GNOME/metacity/commit/074af8f87ef89b13ff326fb5d04ee424bbfd4ced.