search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

Localize unnamed arguments with named arguments and mapping #812

Closed nswarup14 closed 5 years ago

nswarup14 commented 5 years ago

Fixes #807 Changes: i) In the .py files that generated the warnings, the unnamed arguments were resolved with a direct mapping based on what was being translated.

Result: i) The warnings no longer occur. Also i have modified the po/sugar.potfile.

rhl-bthr commented 5 years ago

Thanks. Reviewed and tested on Ubuntu 18.04, Sugar 0.112

rhl-bthr commented 5 years ago

Re reviewed. Found a couple of issues. My tests were incomplete and involved running only the xgettext script to look for warnings.

Here are my changes: 56c3a9d @quozl @nswarup14, please review. My preference is to force push this on sugarlabs/master to avoid a failing build.

quozl commented 5 years ago

Pushed, thanks.

rhl-bthr commented 5 years ago

Thanks. Sorry for the mess