Open rhl-bthr opened 5 years ago
@pro-panda I want to take this issue but before that help me to initiate by understanding the code base so that I can contribute further.
@quozl PTAL
@yshkp, thanks, but you can't take issues. We don't work that way. See our guide to contributing code which says;
Please note there is no need to ask permission to work on an issue. You should check for pull requests linked to an issue you are addressing; if there are none, then assume nobody has done anything. Begin to fix the problem, test, make your commits, push your commits, then make a pull request. Mention an issue number in the pull request, but not the commit message. These practices allow the competition of ideas (Sugar Labs is a meritocracy).
There's nothing stopping anyone else from solving the issue even if you have stated an interest in it.
Also, you should familiarise yourself with the code base and tools; if we had time to guide you, we would have time to fix the issue ourselves. :grin:
@pro-panda this issues needs to be updated the second task is already done.Thanks!
@pro-panda @quozl Can you please explain, what exactly we have to do to fix
[ ] ActivityChooser needs to be made modal
Thanks!
See modal window.
Please see discussion in https://en.wikipedia.org/wiki/Modal_window and https://github.com/pro-panda/sugar/pull/2. I was at fault for discussing in PRs and not on the issue itself.
@pro-panda I am not able to understand how to access or which one is the activitychooserwindow in sugar desktop. Need help. Thanks!
Goto Journal > Projects > Create a new project or select an existing one > Create a new entry
The window that pops up displaying a list of activities to select from is activitychooserwindow
Thanks for explaining. :-)
PopWindow
needs to be moved fromsugar-toolkit-gtk3
tosugar
, in order to remove dependency of toolkit on jarabeSee discussions at https://github.com/pro-panda/sugar/pull/1 and https://github.com/pro-panda/sugar/pull/2