search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

activities.sugarlabs.org is not restricting bundles by Sugar version #818

Open quozl opened 5 years ago

quozl commented 5 years ago

Reproducer: start Browse activity, go to activities.sugarlabs.org, click on News category.

Observed result: GogoNews is offered.

Expected result: GogoNews is not offered, because it is not listed as compatible with 0.112

Reported by: @aperezbios.

tony37 commented 5 years ago

I don't see a connection between the text and the subject. How should ASLO restrict bundles by Sugar version (it doesn't even document the Sugar versions for which the bundles work accurately.

Tony

On 2/14/19 10:24 AM, James Cameron wrote:

Reproducer: start Browse activity, go to activities.sugarlabs.org, click on News category.

Observed result: GogoNews is offered.

Expected result: GogoNews is not offered, because it is not listed as compatible with 0.112

Reported by: @aperezbios https://github.com/aperezbios.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/sugar/issues/818, or mute the thread https://github.com/notifications/unsubscribe-auth/AAULkkz8qoqhsW5PPW-n0J01eKNUxtWbks5vNMjhgaJpZM4a6rqw.

quozl commented 5 years ago

Thanks. You ask how should it be done; here's how it was done. Browse sends HTTP User Agent value containing Sugar version and ASLO would limit search results.

Here's the code in Browse that sends User Agent.

Here's the code in ASLO that reads and parses User Agent.

It's a feature of ASLO that once worked.

ASLO does document the Sugar versions the bundle maintainer listed as compatible. See screenshot of the activity entry;

tmp

That maintainers don't always accurately set this value is indeed interesting.