search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
255 stars 241 forks source link

README.md and docs/ are not in tarball #821

Closed quozl closed 5 years ago

quozl commented 5 years ago

The sugar-*.tar.xz file generated by make dist or make distcheck does not include the file README.md and the directory docs/.

sukhdeepg commented 5 years ago

@quozl I would like to contribute to this. It would really help if you can elaborate on the issue.

quozl commented 5 years ago

I've elaborated. Please proceed.

sukhdeepg commented 5 years ago

@quozl This is what I tried until now: When I ran autoreconf -i and ./configure, it gave me m4 folder and intltool error. Then I tried native sugar method. This generated sugar folder which had m4 folder and thus the ./configure command ran without error. If we add the file name over here: Screenshot from 2019-07-17 22-01-38 The zip which will be created after make dist command will have the specific file. In our case README.md. But this file is generated from the Makefile.am. Each and every folder as a Makefile.am which are included recursively when we run ./configure command. I need your help to understand the Makefile.am structure, so that I can include a new file and folder.

quozl commented 5 years ago

Thanks. But no, I won't help at that level of detail. That would be me fixing the problem. If I were going to fix the problem at the time, I would not have created an issue, but a pull request.

GNU Autotools is a well known open source software product. This ticket would be best worked upon by someone already familiar with GNU Autotools. Alternatively, you might make experimental changes until you find the best and simplest change.

sukhdeepg commented 5 years ago

@quozl, Understood. After digging more and testing, I've made some changes and created a pull request. Please go through it once.

quozl commented 5 years ago

Now that you know something about GNU Autotools, consider helping Aniket with the remaining step in "Port to Six" issue 382 in https://github.com/sugarlabs/sugar-toolkit-gtk3/issues? :grin:

sukhdeepg commented 5 years ago

Will do.

Aniket21mathur commented 5 years ago

Will do.

Thanks @sukhdeepg . Now we are left with the packaging part. As the toolkit supports both Python and Python 3 we should have multi-version packages for the toolkit. It would be great if you help :-)

sukhdeepg commented 5 years ago

Ok 👍