sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
252 stars 240 forks source link

Add Missing dependency intltool #887

Open srevinsaju opened 4 years ago

srevinsaju commented 4 years ago

Dependency intltool was missing from Documentation

Aniket21mathur commented 4 years ago

I don't think explicitly defining intltool as a dependency is a good idea. It gets installed once you build dependencies for sugar. Though I will like to know what others think.

What is the error that you got?

aperezbios commented 4 years ago

I completely disagree. All build dependencies should be explicitly laid out. Nothing should be assumed, including in this case.

srevinsaju commented 4 years ago

@Aniket21mathur This is the error: intltoolize: command not found

quozl commented 4 years ago

Thanks. I agree with both @Aniket21mathur and @aperezbios. Please complete the list of dependencies before making a commit. See my comment in https://github.com/sugarlabs/sugar/issues/884.

Aniket21mathur commented 4 years ago

This is the error: intltoolize: command not found

Thanks, noted. Clearly indicates that the dependencies are not built before installing. Please build before installing. :-)

srevinsaju commented 4 years ago

Seems like I have got the list of rudimentary dependencies required for running sugar on any platform:

Looking forward for comments and corrections, I will add on if more are found. Please review @quozl @aperezbios

quozl commented 4 years ago

Thanks.

But that looks like an Arch list, and it is not correct for Debian or Fedora. If we're going to maintain them, the dependencies must be listed in a form that is not distribution specific. I said this earlier in https://github.com/sugarlabs/sugar/issues/884.

They also have to form part of the commit, not as a pull request comment.

You can find the downstream dependencies on Fedora by looking at the .spec file, and on Ubuntu by looking at the debian/control file.

We used to maintain platform components as a set of dependencies of Sugar and assumed to be present dependencies for activities. That effort died.

srevinsaju commented 4 years ago

should the list be something like this https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Install_the_dependencies

quozl commented 4 years ago

No. Like our previous platform components page, using the formal project name for each dependency. After that we could add distribution-specific package names, but those names rarely match the formal project name. Also, the formal project names rarely change, but distributions often change the package name from release to release.

AakashKota commented 2 years ago

hi, i am Kota Aakash CSE 2nd year well versed with python, django framework, java, css and html5. New to the open source programming looking for guidance

chimosky commented 2 years ago

hi, i am Kota Aakash CSE 2nd year well versed with python, django framework, java, css and html5. New to the open source programming looking for guidance

Hi Kota, you should take a look at our contributing guide which should answer some of your questions, if you have anymore you can send them to the sugar-devel mailing list. Hope that helps!