search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
252 stars 240 forks source link

PEP8 fixes #919

Open Saumya-Mishra9129 opened 4 years ago

Saumya-Mishra9129 commented 4 years ago

https://github.com/sugarlabs/sugar/blob/5b0e880692a679aa6c4179e6579b8202e2524c6a/src/jarabe/model/friends.py#L82

The above line or any such line shows a warning "Unexpected argument". I couldn't be able to get why it so.

Saumya-Mishra9129 commented 4 years ago

https://github.com/sugarlabs/sugar/blob/d59b62a5f1db8c1e1ecb7ccbbcc8b85163290908/src/jarabe/desktop/favoritesview.py#L201

The way we have defined _set_layout is not correct way. Setter should not return any value.

Saumya-Mishra9129 commented 4 years ago

@quozl @pro-panda Please review.

srevinsaju commented 4 years ago

@Saumya-Mishra9129 although, not a big issue, there is a typo on https://github.com/sugarlabs/sugar/pull/919/commits/dbddda340d5ab5173936bf8d471b94dd15543627 's commit message

Saumya-Mishra9129 commented 4 years ago

@quozl Can you please tell me why we used Webkit and Webkit2 support for Sugar.? I am a little confused about it.

quozl commented 4 years ago

@Saumya-Mishra9129, sure, you can see in the commit descriptions of the commits that changed the imports. Some systems on which Sugar is being used did not have WebKit2, so both versions are supported by Sugar.

Saumya-Mishra9129 commented 4 years ago

@Saumya-Mishra9129, sure, you can see in the commit descriptions of the commits that changed the imports. Some systems on which Sugar is being used did not have WebKit2, so both versions are supported by Sugar.

Thanks I am done with changes here @quozl you can review and merge.