sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
252 stars 240 forks source link

Select all button in Journal has no effect. #945

Open chimosky opened 3 years ago

chimosky commented 3 years ago

Steps to reproduce

Nothing helpful shown in logs.

sourabhaa commented 3 years ago

One more observation, this happens only if the name of the file(as mentioned inside activity.info) is not entered completely in the search-box. Example : To select terminal activity, typing at least 'terminal' will give expected results. Anything less than that like 'ter' will result in this error. Also, I noticed if complete name of an activity is searched, the auto search result will include all other activities.

chimosky commented 3 years ago

One more observation, this happens only if the name of the file(as mentioned inside activity.info) is not entered completely in the search-box.

Thanks for that, just noticed this too and it shouldn't have to be the case. @quozl was there any particular reason for this?

Also, I noticed if complete name of an activity is searched, the auto search result will include all other activities.

That's expected given what you mentioned above.

Hope you're doing okay @sourabhaa, been hearing about what's been happening in India.

quozl commented 3 years ago

I tried but can't reproduce. Can you explain further what happens and what you expected?

chimosky commented 3 years ago

I tried but can't reproduce. Can you explain further what happens and what you expected?

When I search for TamTam all the TamTam instances show in the search results and after selecting one, I use the select all button and I expect that everything that came up after the search be selected but what happens is, the selected activity is deselected and the search is automatically cleared.

sourabhaa commented 3 years ago

For more clarity,

  1. Search terminal , all search history of terminal activity is listed, Select all feature works fine (because inside activity.info, name = Terminal).
  2. Search term, all search history of terminal activity is listed, Select all button deselects.
  3. Search terminal activity, all search history of all the activities(which has 'activity' in its name as shown in the search list (not in activity.info)) is listed, Select all button works fine(selects all the activities listed).

That's expected given what you mentioned above.

The third case is what I meant. You mean both 2nd and 3rd case have same cause?

Hope you're doing okay @sourabhaa, been hearing about what's been happening in India.

Thanks for asking @chimosky , I'm in perfect health (but the situation is worsening...)

chimosky commented 3 years ago

The third case is what I meant. You mean both 2nd and 3rd case have same cause?

No, I mean when you search for an activity and include the words "Activity" all activities are bound to show up in the result as they have that in their name when saved as journal objects.

I'm in perfect health (but the situation is worsening...)

Glad you're okay, I hope things change.

quozl commented 3 years ago

I guess I'm still confused. Are you searching activities or Journal objects?

chimosky commented 3 years ago

I guess I'm still confused. Are you searching activities or Journal objects?

Searching for activities in the journal.

quozl commented 3 years ago

Okay, searching for Journal objects that happen to contain activity names because the user did not change the object name.

I don't remember the details of the search entry changes. Best would be to reverse engineer the code. Sam Parkinson added completion.

Vishalk91-4 commented 7 months ago

@quizol is this issue open still For me to work on

quozl commented 7 months ago

Run Sugar to test it if you're not sure.