search

sugarlabs / sugar

Sugar GTK shell
GNU General Public License v3.0
264 stars 245 forks source link

Fix incomplete port to python3 #988

Closed chimosky closed 2 months ago

chimosky commented 3 months ago

Call xdg-user-dirs-update to update xdg directories before looking for any user directory.

@kshitijdshah99 kindly test and review, you can test with Pippy activity, you'll need to build sugar with this branch to test.

Before this change ActivityToolbarButton -> Create a Sugar activity Bundle threw an error, this fixes that.

quozl commented 3 months ago

Reviewed.

chimosky commented 3 months ago

Reviewed.

Thank you!

kshitijdshah99 commented 3 months ago

To confirm that I have perfectly understood this issue

  1. Firstly I have to build live Sugar
  2. Modify the files which you have changed
  3. and then test it Have I addressed the issue correctly?
chimosky commented 3 months ago

To confirm that I have perfectly understood this issue

1. Firstly I have to build live Sugar

2. Modify the files which you have changed

3. and then test it
   Have I addressed the issue correctly?

The first step is correct, you don't have to modify the files which I've changed, you can just pull my changes, and build sugar with my changes, then restart Sugar.

L38-L44 shows you how to build Sugar, you'll have to move the files to your machine directories that exist and is part of the python3 sys.path.

kshitijdshah99 commented 3 months ago

Ok I think now I get the point, I'll try with this and let you know if any issues👍