sugarlabs / turtleart-activity

A block-based Logo programming environment
MIT License
18 stars 54 forks source link

Partial fix to running in non-interactive mode #55

Closed walterbender closed 6 years ago

walterbender commented 6 years ago

These patches are related to https://github.com/sugarlabs/turtleart-activity/issues/30 After applying these patches, the output is now created, but several problems remain: (1) in non-interactive mode, the output is created, but it is blank, even though the code is run (2) in interactive mode, the filename returned from the file selector is blank, so no output is created

quozl commented 6 years ago

Ah, I saw gconf and remembered the other pull request. Now that https://github.com/sugarlabs/turtleart-activity/pull/52 is merged, please rebase?

walterbender commented 6 years ago

Fixes #30 The non-interactive output is appearing correctly. I will open a new issue regarding the file selector bug mentioned above.

walterbender commented 6 years ago

Fixes #56 There was a missing .OK to the response check in the dialog. Seems to work now.

walterbender commented 6 years ago

There was an error in the Gio.settings call for power left over from the GConf code.

walterbender commented 6 years ago

A few more odds and ends missing from the GTK3 port. Also, fixed #46

walterbender commented 6 years ago

Caught a few more places where the toolbar icons were not being set up properly.

walterbender commented 6 years ago

Addressed fullscreen problem referred to in #44 by forcing resize of canvas vbox (both when entering and exiting fullscreen)

quozl commented 6 years ago

Reviewed to 2781942. Want merge yet?

walterbender commented 6 years ago

I think this is ready to merge now... the fix to settings resolved a problem I had encountered with my fix to #30

quozl commented 6 years ago

Reviewed. Tested on Ubuntu 18.04. Tested for #44. Merging.