search

sugarlabs / turtleart-activity

A block-based Logo programming environment
MIT License
18 stars 54 forks source link

Fix help popup message position #92

Closed Dimi20cen closed 1 year ago

Dimi20cen commented 1 year ago

Issue: When horizontally scrolling, a part of the popup help messages would be created in the non-visible part of the screen.

Solution: Change the x value in self.activity.sw.get_vadjustment().get_value(), to be the horizontal adjustment of the screen.

Fixes #75

@chimosky @sourabhaa, kindly review

chimosky commented 1 year ago

Tested 868a773 and issue still persists.

Screencast from 2023-09-22 17-27-23.webm

Dimi20cen commented 1 year ago

The issue this PR addresses is the creation of the popup message when the window is already horizontally scrolled Before Screenshot from 2023-09-23 17-03-35

After Screenshot from 2023-09-23 17-10-43

chimosky commented 1 year ago

Ah! Yes, my bad.