Adding word count in view toolbar

sugarlabs / write-activity

A simple word processor for the Sugar learning environment

GNU General Public License v2.0

2 stars 25 forks source link

Open Daksh opened 8 years ago

Daksh commented 8 years ago

i5o commented 8 years ago

This is enough for the task.

Before we merge we should look another solution for replace the GObject.timeout_add, I tested with idle_add, and didn't worked

samdroid-apps commented 8 years ago

Looks good, here are my overall comments:

does the regex work with languages other than English? Charectersets other than English?
maybe move the label into the activity toolbar (icon: coloured write icon) - there is lots of metadata there already
only update it when the toolbar is open (and therefore when the label is visible)
add a description explaining WHY you used regex rather than an abiword function - explain that abi doesn't expose this apoi

samdroid-apps commented 8 years ago

Actually have a look at abi's algorithm, it looks very efficient and it also deals with other languages. Maybe you could use it?