Update jsquery.nicescroll

sugarlabs / www

The Sugar Labs web site

https://www.sugarlabs.org

GNU General Public License v3.0

71 stars 200 forks source link

Update jsquery.nicescroll #351

Closed quozl closed 2 years ago

quozl commented 2 years ago

[ ] jquery.nicescroll 3.6.8 is in js/jquery-nicescroll.js, but latest is 3.7.6,
[ ] jquery.nicescroll 3.6.8 is taken from CDN by _includes/footer.html instead of from js/

S-kus commented 2 years ago

Here nicescroll is used just for the scrolling of the second header in #sidebar. We can do this without any extra files, i.e. just by adding some CSS styles (I added 4) in the default scrollbar and no need for nicescroll plugin I have tried and it's working similarly to the earlier one. As shown:

Earlier:

before

Now:

after

For this, I just added css in #sidebar from airspace.css and removed the old js/jquery-nicescroll.js. @quozl what are your opinions about this?

quozl commented 2 years ago

I'll defer my opinion until I see the change. If we can avoid having to maintain a dependency, that is better.

S-kus commented 2 years ago

I'll defer my opinion until I see the change.

@quozl Should I raise a pr for this with commit messages so that you can see changes or should I send screenshots of styles in this thread?

chimosky commented 2 years ago

@quozl Should I raise a pr for this with commit messages so that you can see changes or should I send screenshots of styles in this thread?

A PR would be better as anyone can test your changes.

S-kus commented 2 years ago

Thanks, @chimosky. I created the pr for this, Please review it.