Following up to #217 merging the database changes part 2

sugaroverflow / drone-companion-app

collaboration project between Code for Canada + Transport Canada

MIT License

1 stars 3 forks source link

Following up to #217 merging the database changes part 2 #218

Closed sugaroverflow closed 5 years ago

sugaroverflow commented 5 years ago

There was a bunch of stuff missing from #217 merging the database changes - making those changes here.

controllers were not updated
couple of variable names on the frontend

@todo - create an issue for replacing the module dependencies in the controllers - it's hard coded to one, but I will work on this next - wanted to make sure the merge was corrected.

sugaroverflow commented 5 years ago

Hi @xiaoweiguang, please review.

Updated the stuff I think that the merge was missing from the original connect db PR #179. I also removed data/moduleData.json (if we need it later, we can get it back from the history).

You can confirm on https://dronecompanionapp-test.azurewebsites.net/ or your local.

Please merge if all tests pass & changes look okay - otherwise let me know if there's still some stuff that needs to be changed. Thanks!

sugaroverflow commented 5 years ago

Closing this in place of #219 feature/user-model