search

sugendran / node-freetds

nodejs bindings for the freetds lib
7 stars 9 forks source link

Double column types #6

Open tonistiigi opened 10 years ago

tonistiigi commented 10 years ago

Theres an issue when results contain columns in SQLFLT8 type. Not enough memory is allocated and the end is cut off. dbwillconvert returns 10 but this is not enough to keep a string representation of a double. Looking at the docs it even says that it should return bool not int?

This is pretty bad when the initial value is something like 1.2345678e-05 and its converted to 1.2345678.

Gnate commented 9 years ago

Any luck getting this to work?

I must warn you that neither sugendran nor I have been working on this project. You can view the activity of a GitHub project by looking at its `Pulse' (icon on the left panel).

However, I would be happy to update the code if you have made changes and would like to contribute it back to the project. Also, I could be convinced to take a look at this issue if you have not yet solved it yourself.

tonistiigi commented 9 years ago

Hi

If I remember correctly then I fixed it by manually reserving more space for malloc in https://github.com/sugendran/node-freetds/blob/ff922d86daeca14e887e627ceac987ce370d78ce/src/node_freetds.cpp#L218 .

Using this module is the only connection I've had with tds protocol so I didn't look too carefully what was the actual cause for the issue. I don't even have access to the DB any more to test it out, should it ever get fixed. I reported this more like a warning to other people using the module than for a need for a proper fix for my own code.