search

sugyan / yasai

Yet Another Shogi library, for AI development
GNU General Public License v3.0
25 stars 4 forks source link

UB in MASKED_BBS's definition #16

Closed koba-e964 closed 2 years ago

koba-e964 commented 2 years ago

I'm not 100% sure that this is worth an issue, but this line causes undefined behavior. (Bitboard does not allow the 1 << 63-bit to be set)

https://github.com/sugyan/yasai/blob/0.4.0/src/bitboard/core.rs#L75

I'm planning to display warnings against such uses in future shogi_core.

sugyan commented 2 years ago

Thank you for pointing this out! I changed it to create Bitboards after applying a mask in #18.