sugyan / yasai

Yet Another Shogi library, for AI development
GNU General Public License v3.0
25 stars 4 forks source link

Add doc comments & tests. Some refactoring #28

Closed na2hiro closed 1 year ago

na2hiro commented 1 year ago

I'm interested in using (and potentially extending) this library and read the codebase to understand how it works. Along the way,

Please be patient if I do stuff wrong: I'm not very fluent in Rust. And thanks for the great library!

na2hiro commented 1 year ago

Thank you for adding doc comments, tests, and refactoring! It helps a lot. I have submitted a change request to na2hiro#1 regarding fmt. Please check it out. I wrote the answer about Hash in the comment, is this OK?

Thanks for checking this! That looks good and I merged it to the PR.

That makes sense, I removed that TODO comment from code base. Also applied the suggested grammar fixes. Could you check this now? Thanks!