search

suharev7 / clickhouse-rs

Asynchronous ClickHouse client library for Rust programming language.
MIT License
324 stars 121 forks source link

user and password are not percent-decoded #166

Open prk3 opened 2 years ago

prk3 commented 2 years ago

Hi! It looks like clickhouse-rs does not percent-decode username and password strings extracted from DSNs.

https://github.com/suharev7/clickhouse-rs/blob/1be33ab41dba1c99204c848c0a60bbd587a1eb02/src/types/options.rs#L527-L529

Because of that, it's not possible to pass a password containing / or other symbols in DSN. Two other libraries that I checked, mysql-async and lapin, decode username and password strings. Example here:

https://github.com/blackbeam/mysql_async/blob/0778dea4c9a9f851ff41753e92208dcdf3824c40/src/opts.rs#L1003-L1014

suharev7 commented 2 years ago

Hi! Thanks for this issue. This feature was pushed and will be available in the next release.