search

sui77 / rc-switch

Arduino lib to operate 433/315Mhz devices like power outlet sockets.
1.89k stars 653 forks source link

Stale repo, PR's going nowhere? #463

Open greiginsydney opened 2 years ago

greiginsydney commented 2 years ago

Hi @1technophile ,

I see you have write/contributor access to this repo and released the last update back in January 2021.

Lots of people are still blindly contributing PRs but they seem to be going nowhere.

Without an active maintainer is there a point to this, or are their efforts being wasted - or is there a more "lively" fork I should be following (like your own)?

I have a vested interest: I'm using this repo for a soon-to-be-released project of my own, and I'd hope some of those PRs might be accepted to improve the reliability and range of RC devices supported...

- Greig.

1technophile commented 2 years ago

Hi @greiginsydney

Yes, I'm focusing on BLE nowadays but keep an eye on RF. Which PR are you thinking on submitting?

greiginsydney commented 2 years ago

I can't speak for any in particular, but just the general state of this repo. It appears to have been abandoned by its original owner, but it's still popular and people continue to create PRs for it that just languish here... Is there any hope for them??

Locke commented 2 years ago

Well, I would not forbid new PR creation. People should see that PRs are rarely / not merged.

But creating PRs gives them the possibility to at least offer their own changes & forks to others, who might be interesting in the same change, and could then just pick that instead of writing it again and again. Therefore I'd say it not completely wasted effort to have new PRs.

greiginsydney commented 2 years ago

Don't worry @Locke I'm not advocating that the creation of PRs be blocked, but I'd love to see more of that effort incorporated into this repo by merging them rather than spawn 38 (as at today's PR count) new forks.

Is there a way of breathing life back into this repo, or am I flogging a dead horse?

greiginsydney commented 2 years ago

Hey @1technophile , if I was to consolidate a bunch of PRs that add new remote codes (only), would you be amenable to merging the PR and optionally crafting it as a new release?

I can see 6 that are just a single line addition each.

1technophile commented 2 years ago

Hey @greiginsydney, yes but my main concern is that I'm not able to verify that the previously compatible devices will work. If we can have testers helping and confirming the branch I will be happy to do so.

greiginsydney commented 2 years ago

I guess this is the problem with any large open-source project: how can you be sure the code revisions are good?

I've confirmed the addition of the now five new codes (*) don't break the ones I'm using, but that's as far as I can go with it.

(*) I e-mailed one of the authors with a query and they haven't responded.

I'll formalise the PR in the coming day(s) and we'll see what comes of it. Fingers crossed.

- G.

greiginsydney commented 2 years ago

Just created PR #464

mbwhite commented 2 years ago

On a related note, I noticed that WiringPI has stopped been supported. To the extent that the source isn't available anymore.

Alternatives are available, happy to help if I can..

EDIT: actually I've looked up the unofficial wiringPI repo (which I guess is de facto official one now!) and been able to compile that. So that's good news... just trying to see if that all works with RCSwitch and 433Utils (PI)