search

suicidesafetyplan / safetyplan-ios

Suicide Safety Plan is a free mobile application for suicide prevention.
MIT License
20 stars 12 forks source link

Guide View Controllers Objective-C -> Swift Conversion #13

Open NinjaSnail42 opened 4 years ago

NinjaSnail42 commented 4 years ago

Convert the Guide View Controllers to Swift.

shayneptorres commented 4 years ago

@NinjaSnail42 Just noticed that you had EditWarningSignsViewController on your list of views to update. I had already started updating this since it was part of the SafetyPlan view controllers. Were you still planning on working on it?

NinjaSnail42 commented 4 years ago

Yeah sorry, I was listing off the Objective-C files that were in the "Guide" group, but it looks like the .m file is in the "Guide" group, and the header file is in the "Safety Plan" group. You can continue to update it I have not started working on it.

NinjaSnail42 commented 4 years ago

I just wanted to mention that I was still working on this. With everything that has been going on, I have suddenly had a lot more to do, and I have some issues now with Xcode not wanting to show the Swift file in the Assistant editor after I tried to merge....

eddielement commented 4 years ago

That's so odd! Thanks for the update though :)

danispringer commented 9 months ago

Can I try working on this? Is it still wanted/not done yet?

eddielement commented 9 months ago

@DaniSpringer Go ahead! I will keep updating the app :)

danispringer commented 9 months ago

@eddielement I just opened the project and it has several warnings. I can fix those, if you would like to merge that (and can all those fixes be in a single branch or would you need them separated)?

Attaching:

Screenshot of xcode issues list
danispringer commented 9 months ago

@eddielement also: might I ask what RealmSwift is for, and whether it's necessary? If it's the only pod, and can be done without, we might be able to get rid of pods altogether in the project 🍾

eddielement commented 9 months ago

@DaniSpringer All one branch would be great! RealmSwift is the database that is used to store the safety plan, but we could consider shifting it over to Swift Package Manager. :) https://realm.io/realm-swift/

danispringer commented 6 months ago

@eddielement new spm branch much better, just note that the Xcode console printed something about a new version of Realm being available, even while running the app via the spm branch.

Thanks