Feature/native dark mode support

NinjaSnail42 commented 4 years ago

4 Native Dark Mode support for the app.

Notes

To change the text color of the TextViews with attributed text, I had to do it programatically. Since this is the case, I converted the Objective-C code for those three view controllers (which I am currently working on on a different branch anyway.)
I did not change the way that the blue color in the app appears between light and dark mode. I don't think that it looks bad in dark mode, but if we are interested in changing the color between light and dark mode, there are a couple things to know. You can do this by adding color sets, but this is not supported the on older versions of iOS that the app supports. It could also done programmatically, but will be extra work and would be best to do after the entire app is converted from Objective-C to Swift.

Testing

I tested on iOS Simulators with iOS 10.3 (iPhone 5s) and iOS 13 (iPhone 11 Pro Max).

eddielement commented 4 years ago

I just checked over it now and it looks great to me too just with a few merge conflicts to fix. Agreed on the gitignore (although I've tried and failed in the past at ignoring that- maybe there are lots of different DS_Stores?). Thanks for your input too @shayneptorres !

NinjaSnail42 commented 4 years ago

Yeah, apologies for the merge conflict on the storyboard file. I was a dev manager on an iOS project last year for a class at University, and it is quite a pain to fix merge conflicts in the storyboard files.

NinjaSnail42 commented 4 years ago

I fixed the merge conflicts. Had to change repositories from my fork to the actual repo. Should be good for an admin to merge now.

eddielement commented 4 years ago

Whew thank you for that @NinjaSnail42 !! I tried to resolve the conflicts for 30 minutes earlier, it was quite hellish, and I ended up discarding all my changes and was going to try again tonight. I made a few tweaks and I'm merging the changes in now! :)

suicidesafetyplan / safetyplan-ios