suicidesafetyplan / safetyplan-ios

Suicide Safety Plan is a free mobile application for suicide prevention.
MIT License
23 stars 10 forks source link

Issue-22 Add Share plan button on the Plan page #23

Closed pankova closed 2 years ago

pankova commented 2 years ago

Closes #22 The added sharing icon is from SF Symbols app. For this reason, there is no need to add an author info. I've removed the _ic_actionshare icon, as it doesn't seem to be used in the project. If in doubt, I can return.

Testing

Checks

Plan

Warning Signs –

Coping Strategies –

Reasons to Live –

Contacts –

Places for Distraction –

Other –

Plan

Warning Signs –

Coping Strategies –

Reasons to Live –

Contacts –

Places for Distraction –

Other Test filled section

Important I couldn't check the plan with the first five items filled in, because new Xcode 13.2.1 / 13.4.1 builds with some UI bugs:

  1. Transparent splash screen
  2. Transparent navigation bar till I scroll up the screen

The video with 1 and 2: https://user-images.githubusercontent.com/7028613/182032101-e62f3157-217c-4e1d-a312-3a583481197f.mov

  1. Untappable tip textfield and +Add another button. IMG_7883EC9558CF-1]

The reason is new Xcode 13, but I can't install the previous, because macOS Monterey can't work with Xcode earlier, than Xcode 13.

The project needs an issue with adaptation to Xcode 13 – I can create it. As well, It could be useful to decide on supported iOS versions. The current minimum iOS version is 9. If it's decided to support all older variants, this point can be described in the Readme, as this may raise a question in any issue. In another case, the minimum iOS version could be raised, as this can simplify further development.

eddielement commented 2 years ago

This commit looks great! But you're right, it looks like there's a bunch of weird issues when building the app with the new versions of Xcode. Minimum iOS version can definitely be bumped to iOS 13 to make development easier.