Issue-24 Xcode 13 fixes - Githubissues

suicidesafetyplan / safetyplan-ios

Suicide Safety Plan is a free mobile application for suicide prevention.

MIT License

23 stars 10 forks source link

Issue-24 Xcode 13 fixes #25

Closed pankova closed 2 years ago

pankova commented 2 years ago

Closes #24

First: Combining Xcode 13 and iOS 15 had these bugs

Transparent navigation bar until scroll up
Transparent splash screen
Transparent tab bar until scroll up
Untappable buttons and textfields in custom tableview cells

Second: The minimum supported iOS version had been increased to 13 by agreement

Testing

[x] Device: iPhone 12 mini, iOS15.5
[x] Simulator iPhone 13 mini, iOS 15.5
[x] Simulator iPhone 11 Pro Max, iOS 14.5
[x] Simulator iPhone 8, iOS 13.7

Checks

[x] System background color splashscreen: dark for a darkmode, white for a lightmode
[x] Visible nav bar after launch on all screens
[x] Visible tab bar after launch on all screens
[x] Tappable Add another button, one line and two line textfield on EditSafetyPlan screens

eddielement commented 2 years ago

@pankova These changes look great! I merged both pull requests, tweaked a few things, and I can push out an update now unless you wanted to finish anything else. :)