Closed danispringer closed 11 months ago
@eddielement please let me know if this is something you would like me to look into, thanks! (I would need some info though)
@DaniSpringer I just fixed them! :)
@eddielement thanks! How do I go about pulling those changes into my fork of this project? Or should I simply clone the entire project, create local branches for the changes I plan to contribute with, and then would I be able to open PRs from those local branches?
EDIT: I googled, tried some subtree stuff, saw it as too complicated, and decided that, worst case, I will lose the "contribution" stuff on my profile, and that's OK, so I deleted my project and forked the original again. :)
I put it in the refactor/switch-to-spm branch. You can fetch and merge that branch directly into your fork!
On Sun, Dec 24, 2023 at 10:42 AM Daniel Springer @.***> wrote:
@eddielement https://github.com/eddielement thanks! How do I go about pulling those changes into my fork of this project? Or should I simply clone the entire project, create local branches for the changes I plan to contribute with, and then would I be able to open PRs from those local branches?
— Reply to this email directly, view it on GitHub https://github.com/suicidesafetyplan/safetyplan-ios/issues/33#issuecomment-1868409164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2DCU4DBBVS55P6O7627K3YK6B6TAVCNFSM6AAAAABAYGBHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQYDSMJWGQ . You are receiving this because you were mentioned.Message ID: @.***>
-- Eddie
@eddielement cool, how would i do that? I googled it and it looks like I would need to own both ends, but here I only own one (the fork). Thanks!
Try this:
git remote add upstream https://github.com/suicidesafetyplan/safetyplan-ios.git git fetch upstream git checkout your-fork-branch git merge upstream/refactor/switch-to-spm
On Tue, Dec 26, 2023 at 9:17 AM Daniel Springer @.***> wrote:
@eddielement https://github.com/eddielement cool, how would i do that? I googled it and it looks like I would need to own both ends, but here I only own one (the fork). Thanks!
— Reply to this email directly, view it on GitHub https://github.com/suicidesafetyplan/safetyplan-ios/issues/33#issuecomment-1869163207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2DCU4FXJWATEFOULPSK43YLIJPXAVCNFSM6AAAAABAYGBHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE3DGMRQG4 . You are receiving this because you were mentioned.Message ID: @.***>
-- Eddie
Thanks! I had landed on that while Googling but could not tell if that's what I should be doing.
I now see that I cannot push, so my "guess" about permissions was correct, but I guess I don't need to push to that remote, only pull, and then make PRs on my end, etc.
Thank you!
On Dec 25, 2023, at 10:34 PM, eddielement @.***> wrote:
Try this:
git remote add upstream https://github.com/suicidesafetyplan/safetyplan-ios.git git fetch upstream git checkout your-fork-branch git merge upstream/refactor/switch-to-spm
On Tue, Dec 26, 2023 at 9:17 AM Daniel Springer @.***> wrote:
@eddielement https://github.com/eddielement cool, how would i do that? I googled it and it looks like I would need to own both ends, but here I only own one (the fork). Thanks!
— Reply to this email directly, view it on GitHub https://github.com/suicidesafetyplan/safetyplan-ios/issues/33#issuecomment-1869163207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2DCU4FXJWATEFOULPSK43YLIJPXAVCNFSM6AAAAABAYGBHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE3DGMRQG4 . You are receiving this because you were mentioned.Message ID: @.***>
-- Eddie — Reply to this email directly, view it on GitHub https://github.com/suicidesafetyplan/safetyplan-ios/issues/33#issuecomment-1869227635, or unsubscribe https://github.com/notifications/unsubscribe-auth/AES22SNYLCFCLYXGCO435CDYLJAVTAVCNFSM6AAAAABAYGBHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGIZDONRTGU. You are receiving this because you were mentioned.