search

suicidesafetyplan / safetyplan-ios

Suicide Safety Plan is a free mobile application for suicide prevention.
MIT License
23 stars 10 forks source link

Objective C -> Swift #6

Open eddielement opened 4 years ago

eddielement commented 4 years ago

Translate the code from Objective C to Swift to be more futureproof.

shayneptorres commented 4 years ago

I would love to start work on this issue. I think it best that we focus on individual view controllers and create branches with names the reflect the view controller being converted. I also mentioned in this issue that we should establish a gitflow and that all work should be done off a develop branch so everyone isnt merging everything into master

Unless consulted to do otherwise. I will begin working on the CrisisViewController

eddielement commented 4 years ago

I like that approach - I bet for a lot of the view controllers it's going to be very straightforward to feel free to combine them into a single branch. For example, all of the Guide view controllers.

NinjaSnail42 commented 4 years ago

I can work on working on the Guide View Controllers since I am having issues with Dark Mode right now.

tomaszpieczykolan commented 4 years ago

Hey guys, I'd like to contribute a little bit as well :) With the new Swift code, I think it's best to agree on some kind of architecture, to keep things consistent.

shayneptorres commented 4 years ago

@tomaszpieczykolan I agree. Establishing this early would help limit major refactoring later on. Did you have any ideas? We could stick with the a simple MVC or something like MVVM.

eddielement commented 4 years ago

I would lean slightly towards MVC :)

shayneptorres commented 4 years ago

I will begin working on all the Safety Plan View Controllers. The Main SafetyVC and all its sub VCs

danispringer commented 1 year ago

Might be helpful (has helped me in the past) https://swiftify.com/converter/code/