search

suihuanglab / improving-agent

An Autonomous Reasoning Agent in the NCATS Biomedical Translator Network that uses EHR and multi-omic cohorts to rank results from user queries
MIT License
2 stars 4 forks source link

Support qNodes with ids but no categories #42

Closed brettasmi closed 3 years ago

brettasmi commented 3 years ago

As surfaced here https://github.com/NCATSTranslator/minihackathons/issues/11 , the imProving Agent does not support qNodes with qNode IDs but no categories.

This was an intentional design decision that was used for retrieving relevant node-specific identifier regexes to prevent Cypher injection and to skip querying the node normalizer if the identifier is recognized. However, this could be updated to always query the node normalizer regardless and the resulting node category from the node normalizer would allow the retrieval of the relevant regex.

suihuang-ISB commented 3 years ago

@brettasmi - I think this can be considered low priority for now - can we close it?(issue #11) Not sure if "always querying the node normalizer " would drastically increase robustness in the future. Not sure the context this scenario of qNodes w/o category is going to be a frequent scenario? What is the minimal fix to make this issue not appear as error?

brettasmi commented 3 years ago

Fixed as of 2021-09-10