search

suiji / Arborist

Scalable decision tree training and inference.
Other
82 stars 14 forks source link

Statement on code availability in README.md #47

Closed mnwright closed 5 years ago

mnwright commented 5 years ago

Mark, great to see that you continue working on the Arborist.

In the README.md you write in the performance section:

This paper compares several implementations of the Random Forest algorithm, including the Arborist: (https://www.jstatsoft.org/article/view/v077i01/v77i01.pdf). The paper does not include the code on which timings were benchmarked, however, despite the journal's claim to promote reproducible research. As the Arborist has undergone several updates since the paper was written, then, there is unfortunately no way to gauge whether the authors' original findings remain relevant.

The code is included. See https://www.jstatsoft.org/article/view/v077i01.

suiji commented 5 years ago

Thank, Marvin. Please accept my apologies for missing the reference. The URL now appears in the README.

mnwright commented 5 years ago

Thanks!