suikan4github / murasaki

STM32 HAL class library
MIT License
17 stars 3 forks source link

STM32H5 target has warning of the implicit declaration. #153

Closed suikan4github closed 1 year ago

suikan4github commented 1 year ago

Describe the bug During the build of the STM32H503RB, the compiler warns the InitPlatform() and ExecPlatform() are implicitly declared in app_freertos..

The warning messages are shown below :

arm-none-eabi-gcc "../Core/Src/main.c" -mcpu=cortex-m33 -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32H503xx -c -I../Core/Inc -I../Drivers/STM32H5xx_HAL_Driver/Inc -I../Drivers/STM32H5xx_HAL_Driver/Inc/Legacy -I../Drivers/CMSIS/Device/ST/STM32H5xx/Include -I../Drivers/CMSIS/Include -I../Middlewares/Third_Party/FreeRTOS/Source/include/ -I../Middlewares/Third_Party/FreeRTOS/Source/portable/GCC/ARM_CM33_NTZ/non_secure/ -I../Middlewares/Third_Party/FreeRTOS/Source/CMSIS_RTOS_V2/ -I../Middlewares/Third_Party/CMSIS/RTOS2/Include/ -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Core/Src/main.d" -MT"Core/Src/main.o" --specs=nano.specs -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mthumb -o "Core/Src/main.o"
../Core/Src/app_freertos.c: In function 'StartDefaultTask':
../Core/Src/app_freertos.c:113:3: warning: implicit declaration of function 'InitPlatform' [-Wimplicit-function-declaration]
  113 |   InitPlatform();
      |   ^~~~~~~~~~~~
../Core/Src/app_freertos.c:114:3: warning: implicit declaration of function 'ExecPlatform' [-Wimplicit-function-declaration]
  114 |   ExecPlatform();
      |   ^~~~~~~~~~~~

To Reproduce Build the Murasaki application with STM32H503RB.

Expected behavior Warnings should not be shown. To suppress them, the following code should be inserted to app_freertos.c by the installer.

#include "murasaki_platform.hpp"

Note that this may cause double including of the murasaki_platform.hpp in main.c with older MCU. But it is not problematic, actually.

suikan4github commented 1 year ago

Merged to develop. Ready to release.